tests: add quotes to names #5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In podman we also run the bud tests, there I noticed a issue with the podman skip logic as it was unable to fine the build-add-https-retry-ca test name as it always expects quotes[1] In general names should be human readable so add quotes and use spaces over a dash as word separator. [1] containers/podman#24135 Signed-off-by: Paul Holzinger <[email protected]>
|
@edsantiago PTAL |
|
We were not able to find or create Copr project Unless the HTTP status code above is >= 500, please check your configuration for:
|
|
LGTM. Thank you! |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b93b1df
into
containers:main
31 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In podman we also run the bud tests, there I noticed a issue with the podman skip logic as it was unable to fine the build-add-https-retry-ca test name as it always expects quotes[1]
In general names should be human readable so add quotes and use spaces over a dash as word separator.
[1] containers/podman#24135
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?